Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -l/--log-directory option to add logs directory to WACZ #29

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Feb 23, 2023

Connected to #28

This commit additionally formats a few modules with Black to prevent the linter from complaining.

This commit additional formats a few modules with Black to prevent
the linter from complaining.
@tw4l tw4l requested a review from ikreymer February 23, 2023 21:46
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #29 (219b596) into main (8543b3b) will increase coverage by 0.30%.
The diff coverage is 100.00%.

❗ Current head 219b596 differs from pull request most recent head 23e11a4. Consider uploading reports for the commit 23e11a4 to get more accurate results

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   81.50%   81.80%   +0.30%     
==========================================
  Files           4        4              
  Lines         665      676      +11     
  Branches      144      148       +4     
==========================================
+ Hits          542      553      +11     
  Misses         79       79              
  Partials       44       44              
Impacted Files Coverage Δ
wacz/waczindexer.py 82.70% <ø> (ø)
wacz/main.py 88.95% <100.00%> (+0.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder if, just to be extra safe, its worth adding a second log file to the tests?
Or maybe not needed..

@tw4l
Copy link
Member Author

tw4l commented Feb 23, 2023

Sure I can do that quickly!

@tw4l tw4l merged commit bdce681 into main Feb 23, 2023
@tw4l tw4l deleted the issue-28-add-logs branch February 23, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants