Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay Bug]: Browser Crashing & Embedded Video Issues for Arc GIS Storymaps #332

Closed
steinburgb opened this issue Jun 13, 2024 · 1 comment · Fixed by webrecorder/wombat#147
Labels
bug Something isn't working replay bug Archived content is not displaying as expected

Comments

@steinburgb
Copy link

steinburgb commented Jun 13, 2024

ReplayWeb.page Version

v2.0.2

What did you expect to happen? What happened instead?

Working on a strategy for capturing 'storymap' student projects hosted by Arc GIS -- rich single-page sites. Currently running into two issues with them:

  1. Trying replay WACZs of storymaps using ReplayWeb.page in Chrome consistent crashes the browser. Firefox has not given this issue thus far.
    -- This occurs as soon as you open the site's main page

  2. If the storymap contains an embedded Youtube/Vimeo video, when that embedded video would be loaded, the replay of the site "whitescreens" instead.
    -- This occurs when scrolling down the page, just a bit above the location of the embedded video in the live version of the storymap

I have two examples of this on hand, one with an accessible live version of the storymap and the other without:

Example WACZ File:
URL: https://storymaps.arcgis.com/stories/ba4f5e7f25034e4baaf29c88338147d0
WACZ: https://utoronto-my.sharepoint.com/:u:/g/personal/bennett_steinburg_utoronto_ca/EcA-Ulc6_1lIj79d51DFk9gBZTvmzcOl9IgMr04LdVfFxw?e=7DNiYa

Example archive hosted on one of our sites (live counterpart unavailable):
https://collections.digital.utsc.utoronto.ca/test.html

Step-by-step reproduction instructions

No response

Additional details

Part of this issue originally flagged here: https://forum.webrecorder.net/t/media-capture-crashing-embedded-videos-in-arcgis-storymaps/618/2

@steinburgb steinburgb added bug Something isn't working replay bug Archived content is not displaying as expected labels Jun 13, 2024
ikreymer added a commit to webrecorder/wombat that referenced this issue Jun 17, 2024
- use Reflect.set / Reflect.get for doc proxy overrides (fixes document.head assign error on http://datagenetics.com/blog/july12019/index.html, webrecorder/archiveweb.page#195)
- better override for window.frames - resolves to window, so override numeric property on 'window' to fetch frames and add wombat override
- document.querySelector() override, rewrite 'src^=https?', 'href^=https?' query matches to instead be 'src*=' / 'href*=' to match rewritten URLs (fixes shorthand.com sites, eg: https://www.cambridge.org/news-and-insights/five-books-on-climate-action-for-cop28, webrecorder/replayweb.page#272)
- uses wombat.URL instead of window.URL to avoid infinite loop when window.URL is replaced with custom function (fixes webrecorder/replayweb.page#330)
- for document.write override, still assign even in SW to avoid synchronous code failing when expecting written HTML to be there, then still load from blob URL (fixes webrecorder/replayweb.page#332)
- don't intercept assign to '.search' / '.port', as those aren't being rewritten
- check if 'WB_wombat_' is in string before doing regex rewrite, speed up rewrite of very large string
ikreymer added a commit to webrecorder/wombat that referenced this issue Jun 17, 2024
…m sync write() when document is still loading to avoid synchronous code failing when expecting written HTML to be there, then perform service-worker based blob assign from #118 (fixes webrecorder/replayweb.page#332)
ikreymer added a commit to webrecorder/wombat that referenced this issue Jun 17, 2024
…m sync write() when document is still loading to avoid synchronous code failing when expecting written HTML to be there, then perform service-worker based blob assign from #118 (fixes webrecorder/replayweb.page#332) (#147)
@ikreymer
Copy link
Member

@steinburgb this is fixed in 2.0.2. Unfortunately, do to how that youtube embed is set up, it's almost impossible to get it to load due to a race condition. However, the page should otherwise load and not crash or white-screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replay bug Archived content is not displaying as expected
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants