Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

Fix inconsistencies with Pion twcc.go #10

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

kraigher
Copy link

@kraigher kraigher commented Jul 5, 2022

This PR fixes a number of inconsistencies with twcc.go in Pion. I have no idea of how it is supposed to work just that it is not the same so use your own judgement when merging.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #10 (3bf6f6f) into main (e8a4283) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   30.82%   30.76%   -0.07%     
==========================================
  Files          32       32              
  Lines        4522     4522              
  Branches     1186     1185       -1     
==========================================
- Hits         1394     1391       -3     
- Misses       2569     2571       +2     
- Partials      559      560       +1     
Impacted Files Coverage Δ
src/twcc/twcc_test.rs 61.21% <ø> (-0.13%) ⬇️
src/nack/generator/generator_stream.rs 86.95% <0.00%> (-2.18%) ⬇️
src/lib.rs 7.92% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a4283...3bf6f6f. Read the comment docs.

@k0nserv k0nserv merged commit 9226502 into webrtc-rs:main Jul 19, 2022
@k0nserv
Copy link
Member

k0nserv commented Jul 19, 2022

Thanks @kraigher!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants