This repository has been archived by the owner on Aug 23, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. This should fix #7
I've implemented the wrapped adds for the two counters inside a dedicated struct so that the behavior is isolated and easy to test. Apart from running the test suite, is there anything else I should check ? I'm new to the project, any comments / directions are welcome.
I've put the tests in
sender_test.rs
for consistency but would have preferred putting them insender_stream.rs
to avoid having to makeCounter
pub(crate)
visible and makeCounter::mock
a test helper function. What do you think ?Edit: Tested this fix with
webrtc-rs/webrtc 0.4.0
and I was able to display a 4k 30fps h264 stream in Firefox for more than 3 hours without any overflow panic happening.