Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

update deps + loosen some requirements #20

Merged
merged 1 commit into from
Jun 24, 2022
Merged

update deps + loosen some requirements #20

merged 1 commit into from
Jun 24, 2022

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jun 24, 2022

rules:

  • for crates that are below v1.0 -> specify the precise version
  • If the code uses a feature that was added for example in X 0.3.17,
    then you should specify 0.3.17, which actually means "0.3.y where y >=
    17"
  • for crates the are above or equal v1.0 -> specify only major version
    if the crate's API is minimal and won't change between minor versions
    OR specify major&minor versions otherwise

tested with https://github.com/taiki-e/cargo-minimal-versions

rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
  then you should specify 0.3.17, which actually means "0.3.y where y >=
  17"
- for crates the are above or equal v1.0 -> specify only major version
  if the crate's API is minimal and won't change between minor versions
    OR specify major&minor versions otherwise

tested with https://github.com/taiki-e/cargo-minimal-versions
@melekes melekes self-assigned this Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #20 (c7e627c) into main (2d193c0) will decrease coverage by 19.54%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
- Coverage   45.77%   26.22%   -19.55%     
===========================================
  Files          28       28               
  Lines        3216     6238     +3022     
  Branches     1392     2223      +831     
===========================================
+ Hits         1472     1636      +164     
- Misses        305     3009     +2704     
- Partials     1439     1593      +154     
Impacted Files Coverage Δ
src/conn/conn_bridge.rs 44.88% <ø> (ø)
build.rs 25.00% <0.00%> (-25.00%) ⬇️
src/error.rs 2.54% <0.00%> (-9.00%) ⬇️
src/lib.rs 4.93% <0.00%> (-7.57%) ⬇️
src/buffer/buffer_test.rs 23.39% <0.00%> (-2.39%) ⬇️
src/vnet/conn/conn_test.rs 54.23% <0.00%> (+0.84%) ⬆️
src/conn/conn_udp_listener.rs 63.05% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d193c0...c7e627c. Read the comment docs.

@melekes melekes merged commit 142fbc4 into main Jun 24, 2022
@melekes melekes deleted the anton/deps branch June 24, 2022 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant