multiple: modernize code #1668
Merged
multiple: modernize code #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which was still stuck in the 2012 style
nikolov9996
reviewed
Sep 3, 2024
|
|
||
| function onCreateSessionDescriptionError(error) { | ||
| console.log(`Failed to create session description: ${error.toString()}`); | ||
| localStream.getTracks().forEach(track => { |
There was a problem hiding this comment.
looks fine to me, but there is no changes in tests, do the tests work the same way after replacing callbacks with async/await?
There was a problem hiding this comment.
This PR is just refactoring from old style to new style so if the old code was well tested then it will have ensured that this PR did not regress any behavior. Not sure how well tested webrtc samples is in general but what this PR is doing is LGTM
henbos
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which was still stuck in the 2012 style