Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused 'let stream' as it prevents access to window.stream #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeybanez
Copy link

The let stream declaration at the start adds the stream variable to the script's scope. Unfortunately, this means that all references to stream such as in gum() do not refer to the intended window.stream.

In this case, this creates a critical bug where the MediaStreamTrack of the camera is never correctly stopped, which appears to be a necessary step considering how the page already calls getUserMedia() on startup. This results in an OverconstrainedError for all subsequent getUserMedia(constraints) calls, which essentially makes all the resolution tests erroneous.

@octavn
Copy link

octavn commented Jul 18, 2019

For some time now I've been getting nothing but fail: OverconstrainedError for anything above 640x480 with the WebRTC Camera Resolution Finder on Mac & PC with HD+ capable cameras. This could be the cause.

@chadwallacehart
Copy link
Member

I am seeing the same issue. I removed 'stream' and set any references to it to window.stream, but that did not make any difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants