remove unused 'let stream' as it prevents access to window.stream #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
let stream
declaration at the start adds thestream
variable to the script's scope. Unfortunately, this means that all references tostream
such as in gum() do not refer to the intendedwindow.stream
.In this case, this creates a critical bug where the
MediaStreamTrack
of the camera is never correctly stopped, which appears to be a necessary step considering how the page already callsgetUserMedia()
on startup. This results in anOverconstrainedError
for all subsequentgetUserMedia(constraints)
calls, which essentially makes all the resolution tests erroneous.