test: ignore CHROME_BIN/FIREFOX_BIN environment variables #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
force-pushed
the
test-logging
branch
6 times, most recently
from
5bc6a87 to
6cc02fd
Compare
CHROME_BIN already exists on github actions, avoiding the download of the beta/canary version. Also use path.join to join path to browser
fippo
changed the title
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 20, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 20, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 20, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 20, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 20, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 20, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 21, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Apr 21, 2024
following what was done in adapter which is now back to supporting Firefox stable. Also ignore CHROME_BIN environment variable to download the actual Chrome version, see webrtcHacks/adapter#1157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHROME_BIN already exists on github actions, avoiding the download of the beta/canary version.
Also use path.join to join path to browser