Chrome: fix addTrack, removeTrack #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed the wrong button :( |
dagingaa
approved these changes
Dec 10, 2018
|
out of curiosity, where/how did this happen? Surprised this wasn't caught earlier. regression in 7.0.0, I don't think its important enough to backport from 7.1.0 but we could for the sake of Dag-Inge training :-) |
|
@fippo just rebuilt my project (CRA) and checked on the latest version of chrome (71.0.3578.80). And indeed, there was no such problem before; apparently, the condition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chrome_shim.js:490 Uncaught TypeError: Cannot read property 'shimAddTrackRemoveTrackWithNative' of undefined
Purpose
Fix it