Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : add port error bounds to encodePeer #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions client.js
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,14 @@ function createGetResponse (id, token, value) {
return r
}

function encodePeer (host, port) {
const buf = Buffer.allocUnsafe(6)
const ip = host.split('.')
for (let i = 0; i < 4; i++) buf[i] = parseInt(ip[i] || 0, 10)
function encodePeer(host, port) {
const buf = Buffer.alloc(6)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does have a minor logic change in that this will initialize a 0 filled Buffer. I do not know enough about this project to say if that matters.

if (port < 0 || port > 0xffff) throw new Error('port out of bounds')
buf.writeUInt16BE(port, 4)
host.split('.').forEach((octet, i) => {
if (octet < 0 || octet > 0xff) throw new Error('IP out of bounds')
buf.writeUInt8(octet, i)
})
return buf
}

Expand Down