Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.bittorrent.org/beps/bep_0042.html. this PR is just for review; it's definitely not complete.
some stuff to sort out:
socket.createSocket
happens async and callingsocket.address()
in the constructor causes an exception. setting the node ID insocket.on 'listening'
is problematic because other stuff like_debug
also uses nodeId. is there another way to get the address?ip
field different from you think yours is -- libtorrent doesn't seem to do anything about this@feross