Upgrade to Electron 11 #1895
Merged
Upgrade to Electron 11 #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Electron 11 stable was just released. https://www.electronjs.org/releases/stable#release-notes-for-v1100 No breaking changes. |
|
Self-merging without review -- sorry. I want to start testing Electron 11 so we're certain it's stable before the next release. |
|
Sorry for the late review 😓 I've noticed that with I've tested and this error does not appear with I'm trying to find a fix, but I've not find a solution yet 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: Update dep
What changes did you make? (Give an overview)
Upgrade to Electron 11
Which issue (if any) does this pull request address?
Possibly addresses #1894
Is there anything you'd like reviewers to focus on?
I'd like to start testing out Electron 11 on
masterso we can see if there's any deprecated APIs that we need to upgrade, etc. Then when Electron 11 is stable, we can do another release of the app :)UPDATE: Electron 11 stable was just released.