Replaced electron-webrtc with wrtc.
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wrtc@0.1.6` is now working on Node.js.
|
This works awesome, merge please! |
SilentBot1
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Looks good to me, it worked well when I tested it with both instant.io and webtorrent-cli peers.
|
Any idea when this will get into a new version of the npm module? This seems like a much cleaner way to do things than the electron subprocess. |
DiegoRBaquero
approved these changes
Dec 11, 2018
|
@surprisetalk Thanks for making this change. Seems to work a lot better with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrtc@0.1.6is now published to NPM and working on Node.js! Hooray!This should solve issue #76 .
If you're curious on how the problem was solved, feel free to check out this issue in
node-webrtc.