Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新的微信支付证书下载机制 #194

Merged
merged 9 commits into from
Jul 14, 2023
Merged

Conversation

xy-peng
Copy link
Contributor

@xy-peng xy-peng commented Jun 29, 2023

  1. 支持同一个商户重复构造 Config,重复构造会覆盖之前的下载。还是建议全局只构造一个。
  2. 使用一个后台线程,轮询更新证书。
  3. 设置 setDaemon(true),不影响程序推出。
  4. 使用静态类实现的证书更新,也没有(不能)使用抽象类的方式去支持RSA和国密了。

有一个潜在的问题:重复设置之后,可能新的配置有错误不能下载证书,发现不了,暂时没有好办法。如果新配置下载失败时继续沿用之前的配置,从语意上也不是好办法。

@xy-peng xy-peng force-pushed the feat_cert-downloader-manager branch from c5af94c to 7fade17 Compare June 30, 2023 07:55
@xy-peng xy-peng linked an issue Jun 30, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@xy-peng xy-peng merged commit 7d98280 into main Jul 14, 2023
@xy-peng xy-peng deleted the feat_cert-downloader-manager branch July 14, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants