-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoD 2021] Converted all Jekyll blog contributors images to webp #1072
Conversation
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
It seems that error is due to the fact that actual requests are being made to GitHub when running these tests. You can look at these lines of code. Given the number of files you have changed (I suspect you changed the image formats for all contributors to You can add the code below here and then run the tests on your computer. console.log('statusText', response.statusText)
console.log('ok', response.ok) When I did the same, this is what I got. Though you might need to comment out these lines of code to avoid having a congested terminal. I believe one of the solutions could be to split the PR so that each PR is changing image format for not more than 50 contributors, though I have not really tried whether that will work or not. Another option is to merge ignoring the failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you so much for converting all of those image files to .webp
, it's really a great improvement and for our website!
@iamrajiv Yes, I agree with you that the best approach is ignoring the failing tests, and thanks to @nibble0101 for pointing the reason for the failing CI. I noticed that there are two files are conflict with the main branch, please fix those conflicts then I believe we will be able to merge this epic PR! |
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv thanks for the notification. Let's merge this PR first, and please have a double check after this PR has been published. Appreciate to all your efforts to webpify our images! |
webp
webp
webp
Fixes: #1035
Related: #1012