Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSoD 2021] Added blogs on gRPC and OpenAPI #929

Merged
merged 17 commits into from
Sep 7, 2021
Merged

[GSoD 2021] Added blogs on gRPC and OpenAPI #929

merged 17 commits into from
Sep 7, 2021

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Jun 7, 2021 •
edited
Loading

Related: #1012

Screenshot 2021-06-08 at 1 05 36 AM
Screenshot 2021-06-08 at 1 05 31 AM

iamrajiv added 2 commits June 8, 2021 01:11
@iamrajiv
blogs images added
7ecff84 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv
blogs added
dff5049 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv iamrajiv requested a review from a team as a code owner June 7, 2021 19:43
iamrajiv added 5 commits June 8, 2021 01:23
@iamrajiv
added alt to images
9aa158c 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv
added absoluted path
42f330d 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv
added absoluted path
848ff27 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv
added absoluted path
19f5f2b 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv
fixed CI tests
18d39a3 
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@proudofsimin
Copy link
Contributor

Hi @iamrajiv,
I have browsed your PR carefully and felt that I'm in an awkward situation. If it's in Docs I might request some modifications about the structure and writing style, but since it's in a blog post that I would suggest that you keep your style and stay a more conversational way to the readers. How do you think?

Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect PR : clean commit history, properly based, relevant screenshots, PR good in scope.

@iamrajiv iamrajiv mentioned this pull request Jul 10, 2021
Closed
25 tasks
@iamrajiv iamrajiv linked an issue Jul 10, 2021 that may be closed by this pull request
Improve the gRPC and OpenAPI ecosystem #1012
Closed
25 tasks
@iamrajiv iamrajiv removed a link to an issue Jul 10, 2021
Improve the gRPC and OpenAPI ecosystem #1012
Closed
25 tasks
@iamrajiv iamrajiv changed the title Added blogs on gRPC and OpenAPI [GSoD 2021] Added blogs on gRPC and OpenAPI Jul 10, 2021
@iamrajiv iamrajiv requested a review from lijiarui July 11, 2021 01:15
huan
huan approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for sharing those great blog posts for introducing the gRPC and OpenAPI to the community!

@huan huan merged commit 627e45c into master Sep 7, 2021
@huan huan deleted the grpc_openapi_blog branch September 7, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@huan huan huan approved these changes

@proudofsimin proudofsimin Awaiting requested review from proudofsimin

@lijiarui lijiarui Awaiting requested review from lijiarui

Assignees
No one assigned
Labels
GSoD 2021 improve the grpc and openapi ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamrajiv @proudofsimin @huan @Rohitesh-Kumar-Jain