Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoD 2021] Added CHANGELOG file #135

Closed
wants to merge 2 commits into from
Closed

[GSoD 2021] Added CHANGELOG file #135

wants to merge 2 commits into from

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Jun 25, 2021

iamrajiv added 2 commits June 25, 2021 12:23
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Copy link

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @iamrajiv,
You don't need to add me for review as there's nothing I can do to improve document for this PR. Thank you.

@iamrajiv iamrajiv requested review from lijiarui and proudofsimin and removed request for proudofsimin July 11, 2021 01:16
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CHANGELOG is too detailed and I believe the gRPC repo should keep a brief and simple History in the README.md.

My suggestion would be not to have this file.

@Rohitesh-Kumar-Jain
Copy link

As Huan suggested not to have this file I feel the same, hence closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants