Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoD 2021] Added issue and pull request templates #139

Merged
merged 5 commits into from
Sep 8, 2021
Merged

[GSoD 2021] Added issue and pull request templates #139

merged 5 commits into from
Sep 8, 2021

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Jul 2, 2021

Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@iamrajiv iamrajiv changed the title Added issue and pull request templates [GSoD 2021] Added issue and pull request templates Jul 4, 2021
iamrajiv added 2 commits July 5, 2021 21:45
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Copy link

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this idea is cool, but I'm not sure where this PR will be. Is it the replacement of the original notice when we submit a PR like the following picture?
Besides, for this kind of the issue, I would suggest to check with the Wechaty committee for their needs (add or remove any column) before we review it because they are the main users. Otherwise I don't think this PR will gonna be implemented at the end.
image

@iamrajiv iamrajiv requested a review from proudofsimin July 6, 2021 16:36
Copy link

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing me up. I would like to help but since this issue is related to internal communication instead of official documentation, we shall better check with the committee for what they requested for merging. WeChaty committee shall be the decision maker for this kind of issue. I hope you understand.

Copy link

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find anything similar to what you have suggested.

I personally really liked the issue template of pitest-descartes, it was helpful when I had one issue with them.

Wechaty gRPC service, not the whole product so we can avoid using these tags.

Yes, you know better about gRPC than me, so proceed the way you feel. But before proceeding further, as Simin pointed do check the requirements of the org as well.

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those templates, they look good and we can refine it later.

Please change the contributing link to the following

- https://github.com/wechaty/grpc/blob/master/CONTRIBUTING.md
+ https://wechaty.js.org/docs/contributing/

and then I believe this PR can be merged.

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit b1915f2 into wechaty:main Sep 8, 2021
@huan
Copy link
Member

huan commented Sep 8, 2021

Thank you very much for adding those templates to our repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants