-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoD 2021] Added issue and pull request templates #139
Conversation
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this idea is cool, but I'm not sure where this PR will be. Is it the replacement of the original notice when we submit a PR like the following picture?
Besides, for this kind of the issue, I would suggest to check with the Wechaty committee for their needs (add or remove any column) before we review it because they are the main users. Otherwise I don't think this PR will gonna be implemented at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clearing me up. I would like to help but since this issue is related to internal communication instead of official documentation, we shall better check with the committee for what they requested for merging. WeChaty committee shall be the decision maker for this kind of issue. I hope you understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find anything similar to what you have suggested.
I personally really liked the issue template of pitest-descartes, it was helpful when I had one issue with them.
Wechaty gRPC service, not the whole product so we can avoid using these tags.
Yes, you know better about gRPC than me, so proceed the way you feel. But before proceeding further, as Simin pointed do check the requirements of the org as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those templates, they look good and we can refine it later.
Please change the contributing link to the following
- https://github.com/wechaty/grpc/blob/master/CONTRIBUTING.md
+ https://wechaty.js.org/docs/contributing/
and then I believe this PR can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for adding those templates to our repo! |
Related: wechaty/docusaurus#1012