Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear __currentUserId when puppet stops #201

Open
hcfw007 opened this issue Jun 7, 2022 · 0 comments
Open

clear __currentUserId when puppet stops #201

hcfw007 opened this issue Jun 7, 2022 · 0 comments

Comments

@hcfw007
Copy link
Member

hcfw007 commented Jun 7, 2022

In this issue, #184, we discussed that we should not call puppet.logout() in puppet.stop(). That works well, however recently when studying logs about puppet resetting, we found that after reseting the puppet is still logged in before the new login event comes, and that might be problematic.
Thus beside emiting a logout event, we should also clear __currentUserId in puppet.stop(). I'll create a PR to show that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant