You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this issue, #184, we discussed that we should not call puppet.logout() in puppet.stop(). That works well, however recently when studying logs about puppet resetting, we found that after reseting the puppet is still logged in before the new login event comes, and that might be problematic.
Thus beside emiting a logout event, we should also clear __currentUserId in puppet.stop(). I'll create a PR to show that.
The text was updated successfully, but these errors were encountered:
In this issue, #184, we discussed that we should not call puppet.logout() in puppet.stop(). That works well, however recently when studying logs about puppet resetting, we found that after reseting the puppet is still logged in before the new login event comes, and that might be problematic.
Thus beside emiting a logout event, we should also clear __currentUserId in puppet.stop(). I'll create a PR to show that.
The text was updated successfully, but these errors were encountered: