Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logout in stop #202

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Fix logout in stop #202

merged 10 commits into from
Jun 14, 2023

Conversation

hcfw007
Copy link
Member

@hcfw007 hcfw007 commented Jun 7, 2022

@hcfw007 hcfw007 requested a review from a team as a code owner June 7, 2022 06:28
huan
huan requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the improvement!

Basically, the code is good, please follow my reviews.

tests/login.spec.ts Outdated Show resolved Hide resolved
tests/login.spec.ts Outdated Show resolved Hide resolved
src/mixins/login-mixin.ts Show resolved Hide resolved
@huan
Copy link
Member

huan commented Jun 9, 2022

ping

@hcfw007
Copy link
Member Author

hcfw007 commented Apr 25, 2023

Sorry I forgot about this PR.
I used the same mech you wrote in line 140 to line 143.

huan
huan approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

huan
huan previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan enabled auto-merge (squash) June 14, 2023 06:51
@huan huan disabled auto-merge June 14, 2023 08:04
@huan huan merged commit ff8efbf into wechaty:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcfw007 @huan