Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qrcode and dependences #42

Merged
merged 3 commits into from
Apr 30, 2020
Merged

add qrcode and dependences #42

merged 3 commits into from
Apr 30, 2020

Conversation

huangaszaq
Copy link
Contributor

No description provided.

@huangaszaq huangaszaq requested a review from a team as a code owner April 30, 2020 08:21
@huan huan self-requested a review April 30, 2020 08:42
huan
huan approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan
Copy link
Member

huan commented Apr 30, 2020

@huangaszaq Congratulations on passing the CI!

It is great to have you in our Python Wechaty project, we hope the Python Wechaty could be moving faster than before after you joined!

I'm good with this PR and have sent my approval already, and the PR can be able to be merged after it gets two approvals.

@wj-Mcat Please review this PR and feel free to help yourself to merge it after you approved it.

@wj-Mcat wj-Mcat merged commit 6417dd7 into wechaty:master Apr 30, 2020
@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Apr 30, 2020

LGTM

@huan
Copy link
Member

huan commented Apr 30, 2020

@huangaszaq I have invited you to join the GitHub teams of @wechaty/contributors, please accept it by visiting the https://github.com/wechaty

Please also contact @lijiarui so that we can invite you to our contributor WeChat room, welcome and cheers!

@huangaszaq
Copy link
Contributor Author

@huan Thx, I'm glad to hear that. BTW, how can i get the donut token?

@huan
Copy link
Member

huan commented Apr 30, 2020

Great! Looking forward to seeing you in our Contributor WeChat Room.

To apply a donut token, please visit wechaty/wechaty#1941 and send your application by commenting on it. After that, talk to @lijiarui on WeChat and I believe you can get it very quickly.

Please don't hesitate to contact me if you have any questions or concerns.

@huangaszaq
Copy link
Contributor Author

@huan Can't wait! Thx again to invit me to jion Wechaty Team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wj-Mcat wj-Mcat wj-Mcat approved these changes

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangaszaq @huan @wj-Mcat