handle exception when SVGParser::fromString called #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikfrerejean
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Hi @priyashantha,
Thanks for the contribution. I'd like to have these exceptions logged, would be a waste to just have the exception disappear at this point.
| $this->svg = SVGParser::fromString($this->File->getString()); | ||
| try { | ||
| $this->svg = SVGParser::fromString($this->File->getString()); | ||
| } catch (\Exception $e) {} |
There was a problem hiding this comment.
Can you add a logger on the exception? If this fails it would be valuable to have the fail reason logged.
|
@priyashantha I've added logging and merged into main. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.