✨ Use satori for SVG generation #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@CryogenicPlanet everything is ready for review except for the dropdown which is sometimes freezing the page. I retargeted the branch to In a separate pull request to |
|
Merging to |
wei
added a commit
that referenced
this pull request
Nov 19, 2022
* ✨ Use satori for SVG generation * ✨ Create download font script to download from fontsource * 💄 Increase card size to 2x * ⚡️ Move 2 APIs to edge functions * 💄 Fix minor badge style issue * ⚡️ Use edge functions * ♻️ Rename render image helpr files * ♻️ Move files to static folder * 👷 Disable edge function for pages * ⚡️ Remove fonts from edge function to reduce size * ✅ Fix font tests * 💄 Add background color to preview wrapper * ⚡️ Add back react component for display * 🐛 Fix png endpoint cache headers * 🚸 Add intelligent routing for image endpoint * 📱 Fix responsive design * 🚚 Move yoga.wasm to ./public as ./static is deprecated * ⬆️ Upgrade packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use satori for svg generation instead of the previous method of using foreignObject.
Resolved Issues
Cold start is too slow (~ 5-6s) causing GitHub Camo to timeout (4s). We need to switch it to use edge functions runtime, edge api routes
Breaking Change
(satori requires setting both width and height on images. In the future, we can look into pre-fetching the image, calculating the width based on aspect ratio if needed.)
Verdanafont withJostResolves #135, resolves #142.