💡 Warn about overlapping strides if followed by train/val split #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a pro tip about the dangers of using geographical chips created from overlapping strides and then randomly split into train/validation/test sets. Need to raise more awareness that the 'geo' in GeoML matters, because spatial statistics is special 😝 Also fixed an incorrect link to torchdata.datapipes.iter.Batcher.
Preview at https://zen3geo--43.org.readthedocs.build/en/43/chipping.html#slicing-with-xbatcherslicer
Xref xarray-contrib/xbatcher#78 (reply in thread)