✏️ Edit docs to use OGC:CRS84 lon/lat instead of EPSG:4326 #45
+27
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing axis order from x/y instead of y/x! Decided to be a bit more precise after reading into OGC:CRS84 vs EPSG:4326, and audited the user-facing tutorials and API docs for good measure. Noticed too that the vector segmentation mask shapefile is actually in EPSG:9707 and not EPSG:4326, so fixed that. Also made minor edit on first walkthrough tutorial bumping torchdata links from 0.3.0 to 0.4.0.
Set the coordinate reference system for the geo-objects in test_datapipes_datashader.py to use OGC:CRS84 (lon/lat) instead of EPSG:4326 (lat/lon), just to be pedantic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditing the coordinate reference system throughout the documentation and unit tests to use longitude/latitude (OGC:CRS84) instead of latitude/longitude (EPSG:4326) whenever suitable. I.e. an axis order of x/y instead of y/x.
Preview at https://zen3geo--45.org.readthedocs.build/en/45/vector-segmentation-masks.html#load-and-reproject-image-data
References: