✨ GeoPandasRectangleClipper for spatially subsetting vectors #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An iterable-style DataPipe for clipping vector geometries with a raster grid! Uses the rectangular clip algorithm in geopandas.clip for the spatial subsetting. Included a doctest that ensures a geopandas.GeoDataFrame can be clipped by two xarray.DataArray grids. Added a new section in the API docs too.
4 tasks
Ensure that a geopandas.Geoseries vector can be clipped using xarray.Dataset rasters, and that vector datapipes which are too long (len > 1) raise a NotImplementedError properly.
To handle raster images with different coordinate reference systems, do on-the-fly reprojection of the vector geopandas.GeoDataFrame to match the raster xarray.DataArray's coordinate reference system. Have added a unit test with EPSG:3857 and EPSG:32613 chips, and noted this automatic reprojection feature in the docstring. Need to refactor this basic implementation to be more efficient as the whole geodataframe is being reprojected rather than a subset only.
weiji14
added a commit
that referenced
this pull request
Sep 7, 2022
Just a random collection of mostly documentation-related patches. Patches type-hints in #52, isort imports in #35, mention functional name of IterDataPipe in walkthroughs #8 and #20, and remove mention of returned tuple to patch #33. * 🏷️ Add specific type hints for mask_datapipe in geopandas.py Should be either an xarray.DataArray or xarray.Dataset. * 🚨 Sort spatialpandas imports in datashader.py Ran isort to sort spatialpandas.geometry imports alphabetically. Also intersphinx linked the `.crs` attribute to geopandas.GeoDataFrame.crs. * 💬 Mention functional name of IterDataPipe in walkthroughs So people don't get confused on why the class-form like `Collator` is mentioned but `.collate` was used instead. * 📝 Remove mention of tuple being returned in test_pyogrio_reader Forgot to edit the unit test's docstring. Patches #33. * 🍻 It's GeoPackage and GeoDataFrame, not GeoTIFF and DataArray Need to be more careful when copying and pasting stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An iterable-style DataPipe for clipping vector geometries with the rectangular bounding box extent of raster grids!
Preview at https://zen3geo--52.org.readthedocs.build/en/52/api.html#zen3geo.datapipes.GeoPandasRectangleClipper
Needed for #49
TODO:
Possible extensions in future PRs