✨ Implement len function for XbatcherSlicerIterDataPipe #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the number of chips from XbatcherSlicer datapipes to be calculated directly using `len()`! Not previously implemented because it was inefficient in xbatcher, but xbatcher v0.2.0 has implemented lazy batch generation so this should be performant enough now. Also fixed an incorrect intersphinx link to xbatcher.BatchGenerator in the docstring.
Previously turned the datapipes into a list to get the length, now it's possible to avoid the intermediate list representation!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the number of chips from XbatcherSlicer datapipes to be calculated directly using
len()!Not previously implemented (see #22 (comment)) because it was inefficient in xbatcher, but xbatcher v0.2.0 has implemented lazy batch generation (see xarray-contrib/xbatcher#112) so this should be performant enough now.
TODO:
__len__in XbatcherSlicerlen(dp_xbatcher)directly.References: