Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp files not deleted on Windows #325

Closed
itsTyrion opened this issue Jul 26, 2022 · 2 comments
Closed

temp files not deleted on Windows #325

itsTyrion opened this issue Jul 26, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@itsTyrion
Copy link
Contributor

Describe the bug
The temporary native file is not teleted from %temp%.

To Reproduce
Start java app with darklaf, quit it. 1 extra folder + file with every start

Additional Information:

  • OS: Windoze 10
  • OS Version: 21H2
  • Darklaf Version: 3.0.0

Additional context
This is kind of a Windows issue. Deleting a dll after System.load-ing it is pretty complicated.
For my own stuff, I just delete previous temp files on startup. One remaining <100kB dll isn't an issue.

@itsTyrion itsTyrion added the bug Something isn't working label Jul 26, 2022
@weisJ
Copy link
Owner

weisJ commented Jul 28, 2022

I'll look into this. If you want to you can submit a patch for it to speed up the process :)

weisJ pushed a commit that referenced this issue Jul 31, 2022
On Windows the native libraries weren't deleted after jvm shutdown
as expected. This was reported by itsTyrion in #325. This implementation is
based on #326 but makes it more robust against multiple simultaneous uses of
the NativeUtil library (e.g. the auto-dark-mode plugin for IntelliJ also makes
use of it).
@weisJ
Copy link
Owner

weisJ commented Aug 1, 2022

Version 3.0.1 has been released.

@weisJ weisJ closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants