Legit exceptions mechanism

[idanarye]

We often have exceptions bubbling through multiple layers:

TEST/MAYHEM    \                     / handle or crash
                \                   /
wepy.explore     \                 / bubble up
                  \               /
stress0            \             / bubble up
                    \           /
cli                  \exception/

The top layer decides if it is going to continue with the exception or fail the test, but the medium layers still need to make a decision based on the top layer's decision:

1. If the test is going to fail, they want to keep the potentially-corrupted state so that it'll appear in the debug artifacts.
2. If the test is going to continue, maybe they need to fix/rollback (e.g. - s0 may need to resume stressing on a filesystem that has failed to delete? Or stop waiting for a rebooting host to reboot if its reboot was aborted?)

We want to somehow let the top layer mark the exception as legitimate, and as the exception bubbles up the middle layers will base their behavior on the exception's legitimacy.

[koreno]

ExpectedException... :) - Ofer

…

On Mon, Mar 18, 2019 at 3:39 PM Idan Arye ***@***.***> wrote: We often have exceptions bubbling through multiple layers: TEST/MAYHEM \ / handle or crash \ / wepy.explore \ / bubble up \ / stress0 \ / bubble up \ / cli \exception/ The top layer decides if it is going to continue with the exception or fail the test, but the medium layers still need to make a decision based on the top layer's decision: 1. If the test is going to fail, they want to keep the potentially-corrupted state so that it'll appear in the debug artifacts. 2. If the test is going to continue, maybe they need to fix/rollback (e.g. - s0 may need to resume stressing on a filesystem that has failed to delete? Or stop waiting for a rebooting host to reboot if its reboot was aborted?) We want to somehow let the top layer mark the exception as legitimate, and as the exception bubbles up the middle layers will base their behavior on the exception's legitimacy. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#159>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALBR9OagO4-75JlVtHiFb3G5Y2jMQn4ks5vX5cIgaJpZM4b5zYs> .

[doron-cohen]

I think control should be left to the uppermost layer (in this case Mayhem) so it could "freeze" stress0 for example. other than that we could pass exception handlers as objects to decide whether to bubble up or swallow an exception at a lower level.