Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add firewalld and ufw handling during k3s setup #54

Merged
merged 11 commits into from
Jan 29, 2024
Merged

feat: add firewalld and ufw handling during k3s setup #54

merged 11 commits into from
Jan 29, 2024

Conversation

bohdand-weka
Copy link
Contributor

No description provided.

bohdand-weka
bohdand-weka commented Jan 25, 2024
View reviewed changes
Copy link
Contributor Author

@bohdand-weka bohdand-weka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exec.Cmd tells that you have to wait stdout and stderr before calling cmd.Wait so it was changed here as well

@bohdand-weka bohdand-weka merged commit 06a8cd2 into release/v0.4 Jan 29, 2024
2 checks passed
@bohdand-weka bohdand-weka deleted the feat/firewall branch January 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonenidan gonenidan gonenidan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bohdand-weka @gonenidan