Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkksiso: Fix rebuilding the efiboot.img on some systems #1444

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Dec 13, 2024

Check for BOOT.conf or grub.cfg in /EFI/BOOT, and only raise an error in RebuildEFIBoot if the directory is missing.

Fixes #1442

@bcl
Copy link
Contributor Author

bcl commented Dec 13, 2024

NOTE: Currently untested, but it might work :)

bcl added 2 commits December 16, 2024 14:51
Check for BOOT.conf or grub.cfg in /EFI/BOOT, and only raise an error in
RebuildEFIBoot if the directory is missing.

Fixes weldr#1442
pylint or astroid have frequently been broken with python3.13 in
rawhide. Use the latest release for testing for now.
@bcl bcl force-pushed the master-mkksiso-efi branch from d6861e5 to f987ae0 Compare December 19, 2024 00:15
@bcl bcl marked this pull request as ready for review December 19, 2024 00:15
There should only be one. kickstart on the kernel cmdline. This change
automatically replaces an existing inst.ks when `mkksiso --ks KICKSTART
...` is used. Previously this could be done by using `--rm-args
inst.ks`, which still works for compatibility with existing scripts.

Fixes weldr#1320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mkksiso's RebuildEFIBoot() logic checks /EFI/BOOT/BOOT.conf, which doesn't exist on RHEL 9 installers
1 participant