Support GHC 9.4 #298
Merged
Support GHC 9.4 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axman6
reviewed
Aug 22, 2022
| #else | ||
| w# | ||
| #endif | ||
| )))) |
There was a problem hiding this comment.
Can this be a CPP macro instead? Using #if’s everywhere feels messy to me.
There was a problem hiding this comment.
This is the limit of my CPP knowledge - I'd love it if there was an easier way!
coot
added a commit
to input-output-hk/io-sim
that referenced
this pull request
Sep 2, 2022
We still need: * cborg * serialise which support 9.4.2. Both are addressed in well-typed/cborg#298
coot
added a commit
to input-output-hk/io-sim
that referenced
this pull request
Sep 2, 2022
We still need: * cborg * serialise which support 9.4.2. Both are addressed in well-typed/cborg#298
coot
added a commit
to input-output-hk/io-sim
that referenced
this pull request
Sep 3, 2022
We still need: * cborg * serialise which support 9.4.2. Both are addressed in well-typed/cborg#298
|
@FinleyMcIlwaine @bgamari any chance to merge and release this please? |
coot
reviewed
Sep 23, 2022
FinleyMcIlwaine
force-pushed
the
matt/ghc-94
branch
4 times, most recently
from
1940993
to
c966382
Compare
* Remove 8.0.2 and 8.2.2 from tested with * Replace 8.10.1 with 8.10.7 in tested with * Add allow-newer constraint on text for store-core to make benchmarks compile
FinleyMcIlwaine
force-pushed
the
matt/ghc-94
branch
from
c966382
to
8da1a09
Compare
|
Thanks @FinleyMcIlwaine, could you please possibly make a Hackage release any time soon? |
|
@Bodigrim Done, finally 🙂 Apologies for the delay! |
|
Huge thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
This is a very stupid PR, where I use
CPPand then do_fin the 9.4 case to see what to put in. But the tests all pass, so 🎉 🤷🏻