Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Join from the documentation #419

Merged
merged 2 commits into from
May 14, 2021
Merged

Conversation

arybczak
Copy link
Collaborator

@arybczak arybczak commented Apr 15, 2021

Tiny doc improvements that remove references to Join in favor of JoinKinds.

@adamgundry do these look good to you?

@arybczak arybczak requested a review from adamgundry April 15, 2021 17:57
@arybczak
Copy link
Collaborator Author

@adamgundry ping.

Copy link
Member

@adamgundry adamgundry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @arybczak. Sorry that I somehow completely missed this before now. LGTM.

optics/src/Optics.hs Outdated Show resolved Hide resolved
Co-authored-by: Adam Gundry <adam@well-typed.com>
@arybczak arybczak merged commit e704674 into master May 14, 2021
@arybczak arybczak deleted the remove-join-docs branch May 14, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants