Palette-based color picker #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieparkinson
requested review from
davidpmccormick,
gestchild and
jamesgorrie
as code owners
jamesgorrie
reviewed
Jan 27, 2021
jamesgorrie
reviewed
Jan 27, 2021
| const isTouch = (e: InteractionEvent): e is TouchEvent => 'touches' in e; | ||
| const clamp = (x: number, min = 0, max = 1) => | ||
| x > max ? max : x < min ? min : x; | ||
| const useIsomorphicLayoutEvent = |
There was a problem hiding this comment.
I can't see where this is going to be useful? useLayoutEffect is only ever run on the client?
Unless the check is doing something that isn't that?
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Interesting, I wonder if we could just use useLayoutEffect though. Happy for either.
jamesgorrie
reviewed
Jan 27, 2021
common/views/components/PaletteColorPicker/PaletteColorPicker.tsx
Outdated
Show resolved
Hide resolved
jamesgorrie
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an (arguably) improved UI for colour filtering based on the design in Zeplin.
The library we're using doesn't export the plumbing that we want so I replicated it (ish) which makes the UI much better suited to our needs (and doesn't cause CSS import problems).
It looks like this:
