Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assert): allow custom message for ifError #147

Merged
merged 1 commit into from
Mar 24, 2024
Merged

fix(assert): allow custom message for ifError #147

merged 1 commit into from
Mar 24, 2024

Conversation

wellwelwel
Copy link
Owner

Node.js doesn't allow to use a custom message for assert.ifError, but Poku likes it 💡

Thanks to @kusmin for the idea 🤝

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (54d6a2e) to head (0540ddb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   84.82%   87.27%   +2.44%     
==========================================
  Files          27       27              
  Lines        1964     1972       +8     
  Branches      178      194      +16     
==========================================
+ Hits         1666     1721      +55     
+ Misses        290      243      -47     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel merged commit 7252fd4 into main Mar 24, 2024
27 checks passed
@wellwelwel wellwelwel deleted the if-error branch March 24, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant