Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beforeEach and afterEach): end with the proper exit code #471

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Jun 26, 2024

Closes #454.


The fix was implemented during refactoring in PR #469.

This PR only adds coverage tests to ensure that.

@wellwelwel wellwelwel marked this pull request as ready for review June 26, 2024 07:07
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6cc1c54) to head (d494045).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         3486      3484    -2     
  Branches       543       540    -3     
=========================================
- Hits          3486      3484    -2     
Flag Coverage Δ
linux-parallel 99.85% <ø> (-0.01%) ⬇️
linux-parallel-options 99.94% <ø> (-0.01%) ⬇️
linux-sequential ?
linux-sequential-options ?
osx-parallel 95.35% <ø> (-0.01%) ⬇️
osx-parallel-options 95.43% <ø> (-0.01%) ⬇️
osx-sequential 95.20% <ø> (-0.01%) ⬇️
osx-sequential-options 95.29% <ø> (-0.01%) ⬇️
windows-parallel 94.83% <ø> (-0.01%) ⬇️
windows-parallel-options 94.91% <ø> (-0.01%) ⬇️
windows-sequential ?
windows-sequential-options ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel merged commit 716cf5c into main Jun 26, 2024
38 checks passed
@wellwelwel wellwelwel deleted the each-service branch June 26, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeEach and afterEach in-file usage doesn't cause failure exit code when failing
1 participant