Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Accept null for root option #672

Merged
merged 1 commit into from
Oct 22, 2021
Merged

[TS] Accept null for root option #672

merged 1 commit into from
Oct 22, 2021

Conversation

Kerumen
Copy link
Contributor

@Kerumen Kerumen commented Oct 21, 2021

What

Update TypeScript types, add null to root option.

Why

Per the doc, root can accept a null parameter but TS was complaining. This PR fixes that.

@wellyshen
Copy link
Owner

@Kerumen Thank you mate.
@all-contributors please add @Kerumen for bug

@wellyshen wellyshen merged commit f27919d into wellyshen:master Oct 22, 2021
@allcontributors allcontributors bot mentioned this pull request Oct 22, 2021
Merged
@allcontributors
Copy link
Contributor

@wellyshen

I've put up a pull request to add @Kerumen! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerumen @wellyshen