🌐 fix(theme-switcher): properly translate aria-label (#192)

Co-authored-by: Tim Böttcher <tim.boettcher2@rwth-aachen.de> Co-authored-by: welpo <welpo@users.noreply.github.com>
welpo · Oct 4, 2023 · 2eaee65 · 2eaee65
1 parent ab38f84
commit 2eaee65
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/static/js/themeSwitcher.js b/static/js/themeSwitcher.js
@@ -32,7 +32,6 @@ function switchTheme() {
 // Initialize the theme switcher button.
 themeSwitcher.addEventListener("click", switchTheme, false);
 themeSwitcher.setAttribute("role", "button");
-themeSwitcher.setAttribute("aria-label", "Toggle dark mode");
 let togglePressed = currentTheme === "dark" ? "true" : "false";
 themeSwitcher.setAttribute("aria-pressed", togglePressed);
 

diff --git a/static/js/themeSwitcher.min.js b/static/js/themeSwitcher.min.js
diff --git a/templates/partials/theme_switcher.html b/templates/partials/theme_switcher.html
@@ -6,7 +6,7 @@
 
     {%- set combined_mode_str = dark_str ~ "/" ~ light_str -%}
     {%- set title_label = toggle_str | replace(from="$MODE", to=combined_mode_str) -%}
-    {%- set aria_label = 'Toggle ' ~ dark_str ~ ' mode' -%}
+    {%- set aria_label = toggle_str | replace(from="$MODE", to=dark_str) -%}
 
     <div 
         title="{{ title_label }}"