Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: make tubi work with Zola 0.19 #338

Closed
andreacfromtheapp opened this issue Jun 23, 2024 · 6 comments
Closed

Feat: make tubi work with Zola 0.19 #338

andreacfromtheapp opened this issue Jun 23, 2024 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@andreacfromtheapp
Copy link
Contributor

Feature Request

Summary

Zola 0.19.0 is out and there are breaking changes. It would be nice if tabi would update the code to work with it.

Motivation

If I could I'd stick with Zola 0.18 indefinitely but this would benefit everyone.

Detailed Description

Some examples where things break:

  • generate_feed becomea generate_feeds
  • path becomes paginate_path

Additional Context

After the above running zola serve gives:

╰─❯ zola serve
Building site...
Checking all internal links with anchors.
> Successfully checked 0 internal link(s) with anchors.
-> Creating 1 pages (0 orphan) and 6 sections
Error: Failed to serve the site
Error: Failed to render section '/Users/andreacfromtheapp/Sites/gacallea.github.io/content/sound/_index.md'
Error: Reason: Failed to render 'cards.html'
Error: Reason: Function call 'get_url' failed
Error: Reason: Variable `config.feed_filename` not found in context while rendering 'partials/footer.html'

Who knows what else breaks after that (not a criticism, it is a major update on Zola behalf).

Please and thank you

@andreacfromtheapp andreacfromtheapp added the enhancement New feature or request label Jun 23, 2024
@welpo
Copy link
Owner

welpo commented Jun 23, 2024

Hi!

Are you using the latest tabi commit? The footer issue should be fixed with #336

@andreacfromtheapp
Copy link
Contributor Author

Hi!

Are you using the latest tabi commit? The footer issue should be fixed with #336

Hi!

not sure, I ran git submodule update --recursive as well but nothing was fetched.

@andreacfromtheapp
Copy link
Contributor Author

╰─❯ git submodule update --recursive
╰─❯ cd themes/tabi/
╰─❯ git status
HEAD detached at 5ae629d
nothing to commit, working tree clean

@welpo
Copy link
Owner

welpo commented Jun 23, 2024

Try:

git submodule update --remote themes/tabi

@welpo welpo added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Jun 23, 2024
@andreacfromtheapp
Copy link
Contributor Author

thanks!

@welpo
Copy link
Owner

welpo commented Jun 23, 2024

Sorry about the wrong docs regarding updates! Will fix now.

welpo added a commit that referenced this issue Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants