Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 feat: proof of concept pluralization #276

Closed
wants to merge 1 commit into from

Conversation

welpo
Copy link
Owner

@welpo welpo commented Feb 12, 2024

Proof of concept pluralization for testing.

Discussion: #273

The logic to get the strings is in the macro pluralize.html.

To test:

  • Set language to arabic (already done)
  • Modify templates/page.html to change the count variable in the Debugging section
  • Load any post to see a table with the values and translations:

ss

🚨 IMPORTANT: when you change the TOML strings in i18n, you need to restart zola serve to use the updated strings.

@TheAwiteb
Copy link
Collaborator

What should I do if I want to fix something in this PR? Send patch file or send a review?

@TheAwiteb
Copy link
Collaborator

I don't know if I can get a write access to this branch, this will be great

@welpo
Copy link
Owner Author

welpo commented Feb 12, 2024

I don't know if I can get a write access to this branch, this will be great

I don't think this is possible.

How about this: create a new branch on your fork with these changes, and push a new PR here (you can copy the same content). I'll close this one and we can work on your PR.

Sounds good?

@TheAwiteb
Copy link
Collaborator

Sounds good?

Yes

@welpo
Copy link
Owner Author

welpo commented Feb 12, 2024

Work continues on #277

@welpo welpo closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants