Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(remote_text shortcode): support line ranges #399

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Sep 22, 2024

Summary

This PR adds support for line range selection in the remote_text shortcode. Users can now specify start and end line numbers when embedding text from remote or local files.

Related issue

Requested in #397.

Changes

  • Added start and end parameters to the remote_text shortcode
  • Updated the shortcode to slice the text content based on these parameters
  • Updated documentation to explain the new functionality
  • Added examples demonstrating the use of line range selection

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the enhancement New feature or request label Sep 22, 2024
Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit a1a796c
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66f0152949fb2e000884c698
😎 Deploy Preview https://deploy-preview-399--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit b782bae into main Sep 22, 2024
6 of 7 checks passed
@welpo welpo deleted the feat/remote_text-line-range branch September 22, 2024 13:03
@welpo welpo changed the title ✨ feat(remote_text shortcode): support relative paths ✨ feat(remote_text shortcode): support line ranges Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant