More tests on edge cases

wemake-services · Jun 21, 2021 · 2c750f9 · 2c750f9
1 parent aef8362
commit 2c750f9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/...rs/test_ast/test_keywords/test_consistency_returning/test_consistency_return_variables.py b/...rs/test_ast/test_keywords/test_consistency_returning/test_consistency_return_variables.py
@@ -159,6 +159,12 @@ def some():
     return x[0], y, z
 """
 
+correct_example24 = """
+def some():
+    x = 1
+    return -x
+"""
+
 # Wrong:
 
 wrong_example1 = """
@@ -375,6 +381,7 @@ def test_wrong_return_variable(
     correct_example21,
     correct_example22,
     correct_example23,
+    correct_example24,
 ])
 def test_correct_return_statements(
     assert_errors,

diff --git a/tests/test_visitors/test_ast/test_statements/test_almost_swapped.py b/tests/test_visitors/test_ast/test_statements/test_almost_swapped.py
@@ -24,10 +24,16 @@
 b = temp
 """
 
+wrong_double_swap = """
+dx, dy = dy, dx
+dx, dy = dy, dx
+"""
+
 
 @pytest.mark.parametrize('code', [
     wrong_swapped_variables,
     wrong_swapped_variables_with_temp,
+    wrong_double_swap,
 ])
 def test_wrong_swapped_variables(
     assert_errors,

diff --git a/wemake_python_styleguide/visitors/ast/statements.py b/wemake_python_styleguide/visitors/ast/statements.py
@@ -196,7 +196,6 @@ def _almost_swapped(self, assigns: Sequence[ast.Assign]) -> None:
 
             if len(previous_var & current_var) == 1:
                 current_var ^= previous_var
-
             previous_var = current_var
 
     def _check_useless_node(