Detect redundant enumerate

[orsinium]

Rule request

Thesis

# bad
for _, item in enumerate(items):
  ...

# good
for item in items:
  ...

Reasoning

Simplification.

P.S. I'm not making it, have seen it in the wild 🙃

[orsinium]

The same can be applied to dict.items but it apparently requires to know the right type for the iterator. Probably, one more good candidate for typed-linter.

dctnr = {1: 2, 3: 4}
for _, value in dctnr.items():
  ...
for key, _ in dctnr.items():
  ...

[sobolevn]

I will leave this one for typed-linter.

[orsinium]

It will be false-positive only if you have shadowed enumerate function, and I'd say it is a bad practice on its own and you deserve this false-positive then 🙃

[sobolevn]

Yes, my bad!

I was confused by:

dctnr = {1: 2, 3: 4}
for _, value in dctnr.items():
  ...
for key, _ in dctnr.items():
  ...

This should go to typed-linter rule.

[ujju20]

Hello, I am a beginner in the Open source world and I found this issue to be good first so I would like to take this issue. So please guide me.

[sobolevn]

Hi @ujju20!

Make sure to read our contributing guides

Next, you will need to create a new violation and a new visitor, see our glossary what these things mean.

I am here to help: ask anything you need.

[lensvol]

If this is not taken by anybody, can I take it over?

[orsinium]

Sure, go on :)