Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfiniteWhileLoopViolation should allow try: #1857

Closed
sobolevn opened this issue Feb 8, 2021 · 3 comments · Fixed by #1869
Closed

InfiniteWhileLoopViolation should allow try: #1857

sobolevn opened this issue Feb 8, 2021 · 3 comments · Fixed by #1869
Assignees
@Aleksey94Dan
Labels
bug Something isn't working good first issue Entrypoint to the project help wanted Extra attention is needed level:starter Good for newcomers
Milestone
Version 0.15.x

Comments

@sobolevn
Copy link
Member

sobolevn commented Feb 8, 2021

This code does contain raise or break, but you can clearly see that it is meant to be correct.

while True:
   try:
       some_function_that_raises()
   except Exception:
       print('Shut down')
       sys.exit()

So, if while loop has try - it is good enough for us.
@sobolevn sobolevn added bug Something isn't working help wanted Extra attention is needed level:starter Good for newcomers good first issue Entrypoint to the project labels Feb 8, 2021
@Aleksey94Dan
Copy link
Contributor

Hello. Can you assign me this issue? I'd like to contribute. Thanks.

@sobolevn
Copy link
Member Author

@Aleksey94Dan thanks a lot! 👍

@Aleksey94Dan Aleksey94Dan removed their assignment Feb 10, 2021
@Aleksey94Dan
Copy link
Contributor

Sorry.Could you appoint me again? I clicked the wrong place by mistake. Thanks.

Aleksey94Dan added a commit to Aleksey94Dan/wemake-python-styleguide that referenced this issue Feb 10, 2021
@Aleksey94Dan
Fixes bug with InfiniteWhileLoopViolation wemake-services#1857
bc75016
Aleksey94Dan added a commit to Aleksey94Dan/wemake-python-styleguide that referenced this issue Feb 11, 2021
@Aleksey94Dan
Update CHANGELOG.md
22b77cf 
 add wemake-services#1857 to the `CHANGELOG.md`
@sobolevn sobolevn mentioned this issue Feb 11, 2021
Closed
@sobolevn sobolevn added this to the Version 0.15.x milestone Feb 11, 2021
Aleksey94Dan added a commit to Aleksey94Dan/wemake-python-styleguide that referenced this issue Feb 11, 2021
@Aleksey94Dan
Fixes bug with InfiniteWhileLoopViolation wemake-services#1857
46995ca
Aleksey94Dan added a commit to Aleksey94Dan/wemake-python-styleguide that referenced this issue Feb 11, 2021
@Aleksey94Dan
Fixes bug with InfiniteWhileLoopViolation wemake-services#1857
8605545
Aleksey94Dan added a commit to Aleksey94Dan/wemake-python-styleguide that referenced this issue Feb 11, 2021
@Aleksey94Dan
Fixes bug with InfiniteWhileLoopViolation wemake-services#1857
364e18c
This was referenced Feb 11, 2021
Merged
Closed
Aleksey94Dan added a commit to Aleksey94Dan/wemake-python-styleguide that referenced this issue Feb 12, 2021
@Aleksey94Dan
Fixes bug with InfiniteWhileLoopViolation wemake-services#1857
15bd9c0
sobolevn added a commit that referenced this issue Feb 12, 2021
@Aleksey94Dan @sobolevn
Fixes bug with InfiniteWhileLoopViolation #1857 (#1869)
b9e73c3 
* Fixes bug with InfiniteWhileLoopViolation #1857

* Closes #1872

* Closes #1871

* Fixes CI

* Fixes CI

* Fixes CI

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aleksey94Dan Aleksey94Dan

Labels
bug Something isn't working good first issue Entrypoint to the project help wanted Extra attention is needed level:starter Good for newcomers
Projects
None yet
Milestone
Version 0.15.x
Development

Successfully merging a pull request may close this issue.

Fixes bug with InfiniteWhileLoopViolation #1857 Aleksey94Dan/wemake-python-styleguide
2 participants
@sobolevn @Aleksey94Dan