Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant condition in comprehension is not reported #1864

Closed
sobolevn opened this issue Feb 10, 2021 · 1 comment
Closed

Constant condition in comprehension is not reported #1864

sobolevn opened this issue Feb 10, 2021 · 1 comment
Assignees
@sobolevn
Labels
bug Something isn't working
Milestone
Version 0.15.x

Comments

@sobolevn
Copy link
Member

Reproduction:

comp = [num for num in range(5) if True]
@sobolevn sobolevn added the bug Something isn't working label Feb 10, 2021
@sobolevn sobolevn self-assigned this Feb 10, 2021
@sobolevn sobolevn mentioned this issue Feb 11, 2021
Closed
@sobolevn sobolevn added this to the Version 0.15.x milestone Feb 11, 2021
@sobolevn
Copy link
Member Author

The same happens for:

[
    ...
    for x in ...
    if (some if some > 1 else other)
]

It should raise NestedTernaryViolation.

sobolevn added a commit that referenced this issue Feb 11, 2021
@sobolevn
Closes #1864
7657d19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.15.x
Development

No branches or pull requests
1 participant
@sobolevn