fix gpu-onnx infer #2562
Merged
fix gpu-onnx infer #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UnitTest 错误看起来和本PR无关，请 @Slyne 大佬审核下，没啥问题可以直接合并 ：） |
Slyne
reviewed
Jul 4, 2024
There was a problem hiding this comment.
源代码里面有hist_enc为None的情况，len(None)会报错，测试的时候确实也有出现hist_enc为None的情况。
if hist_enc is None:
cur_enc = cur_encoder_out[idx]
.....
cur_mask_len = int(len(hist_enc) + seq_lens[idx])
There was a problem hiding this comment.
Thanks! Didn't realize we changed the initial history cache. FYI, @yuekaizhang Didn't we find this issue before?
There was a problem hiding this comment.
Can you remove the blank lines? Or just use one blank line instead of two lines? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix eos sos to depending on dict or config