Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TemplateType and Project consumers #349

Merged
merged 20 commits into from
Aug 24, 2023

Conversation

Sandro-Meireles
Copy link
Collaborator

@Sandro-Meireles Sandro-Meireles commented Aug 23, 2023

In this PR, 2 consumers are added that listen to RabbitMQ messages and execute their respective business rules:

Queue Consumer class
integrations.template-types TemplateTypeConsumer
integrations.projects ProjectConsumer

In order for the business rules to be testable and reusable, they were developed using some of the S.O.L.I.D concepts such as the Dependency Inversion Principle and the Single Responsibility Principle.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #349 (4b6f3bf) into main (1dd46cd) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   91.17%   91.50%   +0.32%     
==========================================
  Files          85       99      +14     
  Lines        3048     3166     +118     
==========================================
+ Hits         2779     2897     +118     
  Misses        269      269              
Flag Coverage Δ
annotations 91.50% <100.00%> (+0.32%) ⬆️
path 91.50% <100.00%> (+0.32%) ⬆️
test_changes 91.50% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
marketplace/event_driven/consumers.py 100.00% <ø> (ø)
marketplace/applications/usecases/__init__.py 100.00% <100.00%> (ø)
...etplace/applications/usecases/app_configuration.py 100.00% <100.00%> (ø)
marketplace/projects/consumers/__init__.py 100.00% <100.00%> (ø)
marketplace/projects/consumers/project_consumer.py 100.00% <100.00%> (ø)
...place/projects/consumers/template_type_consumer.py 100.00% <100.00%> (ø)
marketplace/projects/usecases/__init__.py 100.00% <100.00%> (ø)
marketplace/projects/usecases/app_setup_handler.py 100.00% <100.00%> (ø)
marketplace/projects/usecases/exceptions.py 100.00% <100.00%> (ø)
marketplace/projects/usecases/interfaces.py 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@Sandro-Meireles Sandro-Meireles force-pushed the feature/eda-projects-consumers branch from d0bdf4d to 0dfc011 Compare August 23, 2023 23:30
@Sandro-Meireles Sandro-Meireles merged commit c88b32b into main Aug 24, 2023
@Sandro-Meireles Sandro-Meireles deleted the feature/eda-projects-consumers branch August 24, 2023 21:02
@Sandro-Meireles Sandro-Meireles changed the title Create TemplateType and Project consumers and handle queues Create TemplateType and Project consumers Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants