Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template analytics viewset and services #361

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

elitonzky
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #361 (d6296cd) into main (5b5d622) will increase coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   92.64%   92.83%   +0.18%     
==========================================
  Files         103      106       +3     
  Lines        3306     3392      +86     
==========================================
+ Hits         3063     3149      +86     
  Misses        243      243              
Flag Coverage Δ
annotations 92.83% <100.00%> (+0.18%) ⬆️
path 92.83% <100.00%> (+0.18%) ⬆️
test_changes 92.83% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
marketplace/wpp_templates/analytics/serializers.py 100.00% <100.00%> (ø)
marketplace/wpp_templates/analytics/views/views.py 100.00% <100.00%> (ø)
marketplace/wpp_templates/services/facebook.py 100.00% <100.00%> (ø)

@elitonzky elitonzky force-pushed the feature/template-analytics branch from 1c88c71 to 3db65b7 Compare October 4, 2023 22:36
@elitonzky elitonzky force-pushed the feature/template-analytics branch from 3db65b7 to 11f6527 Compare October 5, 2023 12:59
Copy link
Contributor

@lucaslinhares lucaslinhares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but could raise a ValidationError when app different of 'wpp-cloud, wpp'. That way is not clear when the error is about code error or app doesn't exist.

image

@elitonzky elitonzky merged commit b39e46c into main Oct 13, 2023
4 checks passed
@elitonzky elitonzky deleted the feature/template-analytics branch October 13, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants