Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Verisign parser to the new response #57

Merged
merged 8 commits into from
Aug 3, 2017
Merged

Conversation

phcyso
Copy link
Contributor

@phcyso phcyso commented Jul 31, 2017

It appears verisign has updated the wording for the expiry date for .com domains
Confimed with:

# whois -h whois.verisign-grs.com google.com
   Domain Name: GOOGLE.COM
...
   Registry Expiry Date: 2020-09-14T04:00:00Z
...

@weppos
Copy link
Owner

weppos commented Jul 31, 2017

The change is breaking the build, and also it doesn't include appropriate test updates and fixtures. Please provide the appropriate test updates as well.

@phcyso
Copy link
Contributor Author

phcyso commented Aug 1, 2017

@weppos Sorry about that, i didn't think to check the specs.
Have updated the rest of the changed fields and updated the fixtures and specs to match.

I am not sure how the ./spec/fixtures/responses/whois.verisign-grs.com/com/property_registrar_with_multiple_entries.txt was originally created as my whois clients on osx and linux only return one record now so i have updated this file to match the new field name manually.

@weppos
Copy link
Owner

weppos commented Aug 3, 2017

Thanks @phcyso, that's a great help!

I am not sure how the ./spec/fixtures/responses/whois.verisign-grs.com/com/property_registrar_with_multiple_entries.txt was originally created as my whois clients on osx and linux only return one record now so i have updated this file to match the new field name manually.

I was unable to reproduce it. It looks like Verisign finally decided to turn the default to an exact match search:
weppos/whois@b28c9ed

I'll remove the fixture and the test.

@weppos
Copy link
Owner

weppos commented Aug 3, 2017

@phcyso how did you generate the fixtures? Did you use the mkwhois tool? It looks like the fixtures you added contains both the verisign and the referral response, whereas they should only include the one from verisign.

@weppos weppos self-assigned this Aug 3, 2017
@weppos
Copy link
Owner

weppos commented Aug 3, 2017

Actually, I may be wrong, the fixtures seem correct.

@weppos weppos merged commit 8709d1e into weppos:master Aug 3, 2017
weppos added a commit that referenced this pull request Aug 3, 2017
@weppos weppos changed the title Fix expires_on check for verisign domains Update Verisign parser to the new response Aug 3, 2017
weppos added a commit that referenced this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants