Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VAD parameter to the VST plugin. #20

Merged
merged 3 commits into from
May 18, 2020
Merged

Added VAD parameter to the VST plugin. #20

merged 3 commits into from
May 18, 2020

Conversation

theglobe
Copy link
Contributor

I followed an example in the LV2 plugin for creating enum class Parameters.

theglobe added 2 commits May 15, 2020 01:17
@theglobe
Added VAD parameter to the VST plugin.
b8b2d6d
@theglobe
Cleared label of VAD parameter.
c8ba5a9 
It's intended use seems to be as the unit of the parameter,
shown after the value.
werman
werman requested changes May 16, 2020
View reviewed changes
Copy link
Owner

@werman werman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are just two small changes left.

Also what app did you use for testing? And if possible, could you briefly test it with "Equalizer APO" since it's an app mentioned in the readme.

src/vst_plugin/RnNoiseVstPlugin.cpp Outdated Show resolved Hide resolved
src/vst_plugin/RnNoiseVstPlugin.h Outdated Show resolved Hide resolved
@theglobe
Copy link
Contributor Author

I'm testing with Davinci Resolve, Ableton Live and VSTHost
https://www.kvraudio.com/product/vsthost-by-hermann-seib

@werman werman merged commit 6c5b938 into werman:master May 18, 2020
@werman werman mentioned this pull request Jul 16, 2020
Closed
@githubplanetarparrot
Copy link

How do you actually use the VAD function through something like VSTHost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werman werman werman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theglobe @githubplanetarparrot @werman